chore: switch to tinyglobby #1958
Conversation
benmccann
force-pushed
the
tinyglobby
branch
from
c9454d1 to
678b2bc
Compare
|
@prklm10 I just rebased this to address the merge conflicts. Any chance you could give it a look? It's a bit cumbersome to keep up-to-date |
benmccann
force-pushed
the
tinyglobby
branch
3 times, most recently
from
cc8d4b6 to
22fdb4a
Compare
|
@prklm10 @pankaj443 @ninadbstack I'm terribly sorry to bother you, but would I be able to get you to take a look at this PR? I've been trying to keep it updated and it's a bit hard to keep it free of merge conflict |
benmccann
force-pushed
the
tinyglobby
branch
from
22fdb4a to
3adebe9
Compare
|
@prklm10 @pankaj443 @ninadbstack please any chance that you could look at this? It's a pretty small straightforward PR |
| "image-size": "^1.0.0" | ||
| "image-size": "^1.0.0", | ||
| "tinyglobby": "^0.2.15" | ||
| } |
There was a problem hiding this comment.
This does remove a bit of the fast-glob (for good reasons - https://superchupu.dev/tinyglobby) so reduces the runtime size, so good imo. Fellas, let the tests run to give @benmccann feedback, so we can speed up install a bit, speeding up CI's for percy-cli users.
|
This PR is stale because it has been open for more than 14 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
|
not stale |
|
This PR is stale because it has been open for more than 14 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
|
Not stale |
|
This PR is stale because it has been open for more than 14 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
|
@prklm10 @pankaj443 @ninadbstack any chance this PR could get a review so I don't have to keep marking it as not stale? |
|
This PR is stale because it has been open for more than 14 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
|
Not stale |
2 participants
https://npmgraph.js.org/?q=fast-glob - 17 dependencies
https://npmgraph.js.org/?q=tinyglobby - 2 dependencies