feat: default archive_on_destroy to true and has_downloads to false - #14
Merged
Conversation
Archiving a repository on destroy is safer than permanently deleting it. Consumers can still opt out per-repo with archive_on_destroy = false.
josmo
changed the title
The GitHub Downloads section is a deprecated legacy feature superseded by Releases. Defaulting it off matches GitHub's effective default and avoids spurious drift on existing repositories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Archiving a repository on destroy is safer than permanently deleting it. Consumers can still opt out per-repo with archive_on_destroy = false. Also set has_downloads to false (deprecated ages ago)
What & why
Safer to have archive on destroy true by default
Checklist
terraform fmt -recursiveis cleanpre-commit run --all-filespasses (docs regenerated if inputs/outputs/resources changed)terraform testpasses for any submodule I changedBreaking changes
default to archive