fix: Increase display_color column length to 7 in the generic OIDC pr…

[KyleDerZweite]

Minor change: QoL Improvement.
Increased the length of the 'display_color' field from 6 to 7 characters to accommodate additional color formats. Previously it shortened my "#8b5cf6" to "#8b5cf" which is an entirly different color.

Summary by CodeRabbit

• Chores
  • Updated system infrastructure to accommodate longer display color value formats in authentication provider settings. This change expands storage capacity for color identifiers, supporting additional naming conventions and preparing the platform for future enhancements. The modification is transparent to end users and maintains full backward compatibility.

[coderabbitai]

📝 Walkthrough

Walkthrough

A database schema migration increases the display_color column length from 6 to 7 characters in the generic_oidc_providers table, allowing storage of slightly longer color values without functional logic changes.

Changes

Cohort / File(s)	Summary
Database Schema Migration generic-oidc-providers/database/migrations/001_create_generic_oidc_providers_table.php	Increased display_color column length from 6 to 7 characters, enabling extended color value storage.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

• pelican-dev/plugins#104: Directly addresses the same schema migration and column modification (display_color length increase from 6 to 7).

Poem

🐰 A whisker of change, so small yet so bright,
Seven's the magic that sets colors right,
From six tiny chars to a seventh one more,
The display will gleam like it never before! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Merge Conflict Detection	⚠️ Warning	⚠️ Unable to check for merge conflicts: Stream setup permanently failed: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error)

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change—increasing the display_color column length from 6 to 7 characters in the generic OIDC providers table, which directly addresses the truncation issue mentioned in the PR description.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

⚔️ Resolve merge conflicts (beta)

• Auto-commit resolved conflicts to branch kylederzweite
• Post resolved changes as copyable diffs in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In
`@generic-oidc-providers/database/migrations/001_create_generic_oidc_providers_table.php`:
- Line 17: Create a new migration (don't modify the original) that alters the
generic_oidc_providers table to change the display_color column length to 7 so
existing installs are fixed; in the migration's up() use
Schema::table('generic_oidc_providers', ...) and call
$table->string('display_color', 7)->nullable()->change(); and in down() reverse
it (e.g. change back to string('display_color', 6)->nullable()->change()) so the
migration is reversible.

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 29ebf81 and a39c952.

📒 Files selected for processing (1)

• generic-oidc-providers/database/migrations/001_create_generic_oidc_providers_table.php

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

[KyleDerZweite]

Also i've run in the ALTER TABLE generic_oidc_providers MODIFY display_color VARCHAR(7); to migrate my running database. Just if anyone needs that aswell.
Must be run inisde the db container.

or theoretically if no data is currently stored, u could rollback and then re-migrate (only in dev, never in prod):
php artisan migrate:rollback --step=1
php artisan migrate

[Boy132]

Good catch! Thank you!