Repository navigation
Qualify Workspace sdist rebuild and installed wheel parity - #37
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LANE_4 r3: qualify the sdist rebuild path
This is the bounded
L4-WORKSPACE-SDIST-ROUNDTRIP-V1-20261001pickup in Forge #208. The direct wheel from PR #36 passed its own installed gate, but an actual2.4.1sdist omittedproduct-version.json, so rebuilding a wheel from that archive failed withFileNotFoundError. The existing WPK-PACKAGE acceptance explicitly requires a usable sdist rebuild.MANIFEST.innow includes the canonical version source. Requiredbash scripts/validate.shbuilds both direct wheel and sdist, verifies source presence/version, rebuilds a wheel from the archive in a separate disposable environment, compares package files and role metadata with the direct wheel, and installs the rebuilt wheel non-editably outside the checkout. Negative tests reject missing sdist source and divergent rebuilt product bytes. Product version 2.4.2 is one PATCH operation under the existing policy. Owning backlog/roadmap/DAG text distinguishes this candidate from already merged local wheel evidence and the still-open public WPK parent.Candidate evidence at
85373cf2.4.1sdist rebuild failed becauseproduct-version.jsonwas absent.bash scripts/validate.sh: PASS at 2.4.2, including strict per-file runtime coverage:__init__.py8/8 (100%),cli.py45/46 (97.83%),http.py83/96 (86.46%),service.py86/90 (95.56%).git diff --check: PASS. Independent read-only review at exact head85373cf8007fedc44107dc5b4a4230414b4c66acfound no actionable issues; this is not a GitHub approval.36895133854and version-source check: SUCCESS. Non-blocking TDE observe run36895133691: workflow SUCCESS; downloaded artifact reports assessmentPASS_WITH_WARNINGS, repository qualificationQUALIFIED,assessment_exit=1,qualification_exit=1, andcoverage_evidence=not_available_for_foundation_only_repository. This is observation, not a runtime-TDE PASS.This is neither bitwise reproducibility nor public namespace/publisher/release qualification. No peer source, production runtime, public registry, installer, Mission, reset, T0 or host service is changed. The first installer DoD remains unchanged.
Protected merge and main readback
PR #37 was protected squash-merged at
d4fa4365786c38e8d8d0d62069665678a15a8abd; its source tree matches the reviewed head exactly. On this exactmain,bash scripts/validate.shpassed again with the same strict per-file coverage, sdist rebuild, semantic wheel parity and fresh installed-role checks. Exact-main Workspace CI36895373047and canonical versioning36895373061: SUCCESS. Non-blocking TDE observe36895373069: workflow SUCCESS; artifactPASS_WITH_WARNINGS/QUALIFIED,assessment_exit=1,qualification_exit=1, and no TDE coverage evidence. This is still observation, not runtime-TDE qualification. WPK-IDENTITY, full WPK-PACKAGE and public release/readback remain open.