Raise CaptionReadTimingError for a non-numeric SAMI start time - #418
Open
eeshsaxena wants to merge 1 commit into
Open
Raise CaptionReadTimingError for a non-numeric SAMI start time#418eeshsaxena wants to merge 1 commit into
eeshsaxena wants to merge 1 commit into
Conversation
The SAMI reader converted a SYNC element's start attribute with int(float(start_str)), raising a bare ValueError when the value was not numeric. A missing start already raises CaptionReadTimingError, so raise the same error for an unparsable one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SAMI reader raises a bare
ValueErrorwhen a<SYNC>element'sstartattribute is not numeric:_translate_langdoesint(float(start_str)). A missing start time already raisesCaptionReadTimingError, so I wrapped the conversion to raise the same error ("Invalid start time ...") for an unparsable one. Valid SAMI is unchanged.Added a test next to
test_missing_start; it raises ValueError onmainand passes with the change. Found it by fuzzing the readers with mutated captions.