Skip to content

chore: make overrideAccess explicit in examples - #17865

Draft
nathanlentz wants to merge 1 commit into
override-access/templatesfrom
override-access/examples
Draft

chore: make overrideAccess explicit in examples#17865
nathanlentz wants to merge 1 commit into
override-access/templatesfrom
override-access/examples

Conversation

@nathanlentz

Copy link
Copy Markdown
Collaborator

Adds an explicit overrideAccess: true to every Local API call in examples/ that
previously relied on the default. 120 insertions across 28 files, in 9 examples.

This is preparation for making overrideAccess a required property, which lands later
in this stack. It is split out so that the breaking change itself stays small enough
to read.

This changes no behaviour

The Local API currently defaults overrideAccess to true. Writing the value explicitly
produces exactly what the default already produced.

Example Files
localization 9
multi-tenant 5
live-preview 3
remix, form-builder, draft-preview, auth, astro 2 each
custom-components 1

The eight deletions are one-line object literals that became multi-line once the property
was added, plus one pre-existing over-long function signature that Prettier reflowed in
localization/src/utilities/getGlobals.ts.

Verification

Examples are standalone projects with no dependencies installed, so they cannot be
typechecked. Call sites were enumerated from the AST instead, and a re-scan after the
sweep reports zero remaining.

Two sites needed hand-editing because the codemod deliberately skips any object
containing a spread — it cannot know whether the spread already supplies the property.
Both were conditional where clauses that do not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant