chore: make overrideAccess explicit in examples - #17865
Draft
nathanlentz wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an explicit
overrideAccess: trueto every Local API call inexamples/thatpreviously relied on the default. 120 insertions across 28 files, in 9 examples.
This is preparation for making
overrideAccessa required property, which lands laterin this stack. It is split out so that the breaking change itself stays small enough
to read.
This changes no behaviour
The Local API currently defaults
overrideAccesstotrue. Writing the value explicitlyproduces exactly what the default already produced.
localizationmulti-tenantlive-previewremix,form-builder,draft-preview,auth,astrocustom-componentsThe eight deletions are one-line object literals that became multi-line once the property
was added, plus one pre-existing over-long function signature that Prettier reflowed in
localization/src/utilities/getGlobals.ts.Verification
Examples are standalone projects with no dependencies installed, so they cannot be
typechecked. Call sites were enumerated from the AST instead, and a re-scan after the
sweep reports zero remaining.
Two sites needed hand-editing because the codemod deliberately skips any object
containing a spread — it cannot know whether the spread already supplies the property.
Both were conditional
whereclauses that do not.