fix(drizzle): preserve failing sub-table on unique-constraint ValidationError#17014
Open
GermanJablo wants to merge 2 commits into
Open
fix(drizzle): preserve failing sub-table on unique-constraint ValidationError#17014GermanJablo wants to merge 2 commits into
GermanJablo wants to merge 2 commits into
Conversation
…ionError When a Postgres/SQLite unique-constraint violation on an array/block sub-table is converted into a ValidationError, only the bare column name (typically `id`) was preserved, so editors saw "The following field is invalid: id" and afterError hooks had no way to identify the affected field/block. `handleUpsertError` already knows the failing `tableName`; this exposes it on the thrown ValidationError's field error so afterError hooks can map the failure back to a collection field/block. The dotted field path is deliberately not resolved at insert time: doing that required per-row inserts and caused data loss in the previous attempt (#15754). This change does not touch insert mechanics.
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
When a database-level unique-constraint violation (Postgres
23505/ SQLiteSQLITE_CONSTRAINT_UNIQUE) is raised on an array/block sub-table and converted into aValidationErrorinhandleUpsertError, only the bare column name (typicallyid) was preserved. The failing sub-table name and original constraint detail were discarded.As a result:
afterErrorhooks cannot enrich the message, because by the time they runValidationError.dataonly containspath: "id".Closes #16965.
How?
handleUpsertErroralready receives the failingtableName. This PR adds an optionaltableNametoValidationFieldErrorand populates it when throwing the constraintValidationError, soafterErrorhooks can map the failure back to a collection field/block.The dotted field path is intentionally not resolved at insert time. The previous attempt (#15754) did that by switching from a batch insert to per-row inserts to recover a per-row block path, and it was closed by its author because it caused data loss. This change is purely diagnostic and does not touch how rows are inserted.
Notes
Tests
handleUpsertError.spec.ts(unit): asserts a23505on an array sub-table throws aValidationErrorcarryingtableName, and that non-constraint errors are re-thrown unchanged.