Add publish --dry-run check in release issue#1633
Open
benalleng wants to merge 1 commit into
Open
Conversation
Collaborator
Coverage Report for CI Build 27222540493Coverage remained the same at 85.199%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
DanGould
requested changes
Jun 10, 2026
| - Make sure the tag is signed, for extra safety use the explicit `--sign` flag. | ||
| - [ ] Wait for the CI to finish one last time. | ||
| - [ ] Build the docs locally to ensure they are building correctly. | ||
| - [ ] Check that the crate is publishable with `cargo publish --dry-run` from that crate's directory. |
Contributor
There was a problem hiding this comment.
I think this line is right but it needs to be done before the tag is pushed to GitHub (which isn't said explicitly here but is implied by "Wait for the CI to finish one last time". IMO it should be done as the first step here to prevent the tag work from needing to be redone.
benalleng
force-pushed
the
release-checklist
branch
from
225ab14 to
0c7738a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Up to you @DanGould if this is the right place to put it
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.