Make Cargo-minimal and Cargo-recent lockfiles follow expected convention#1612
Open
benalleng wants to merge 6 commits into
Open
Make Cargo-minimal and Cargo-recent lockfiles follow expected convention#1612benalleng wants to merge 6 commits into
benalleng wants to merge 6 commits into
Conversation
Collaborator
Coverage Report for CI Build 27285085924Coverage remained the same at 85.244%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
benalleng
force-pushed
the
lockfile-correctness
branch
from
13a6c1c to
31dd86b
Compare
benalleng
force-pushed
the
lockfile-correctness
branch
4 times, most recently
from
0eff67a to
e0182f0
Compare
benalleng
force-pushed
the
lockfile-correctness
branch
6 times, most recently
from
1735564 to
36266b3
Compare
Add a new lockfile backups script to make sure lints and tests are locked to Cargo-recent.lock
benalleng
force-pushed
the
lockfile-correctness
branch
from
36266b3 to
3e77c6c
Compare
Collaborator
Author
|
This should avoid cargo updates from occuring on stray CI jobs preventing failures like https://github.com/payjoin/rust-payjoin/actions/runs/27285126244/job/80590095693?pr=1629 in efc5b92 from happening |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Cargo-minimal and Cargo-recent lockfiles were not actually pointing to the minimal and recent semvers of the dependencies and were instead just copies of the Cargo.lock lockfile.
This is somewhat related to the release but I don't think its all that critical just something that I thought should be improved.
Relates to #940 though I'm not sure it should close it
also related is #454
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.