Skip to content

Ohttp middleware#1609

Open
zealsham wants to merge 1 commit into
payjoin:masterfrom
zealsham:ohttp-middleware
Open

Ohttp middleware#1609
zealsham wants to merge 1 commit into
payjoin:masterfrom
zealsham:ohttp-middleware

Conversation

@zealsham

@zealsham zealsham commented Jun 6, 2026

Copy link
Copy Markdown
Collaborator

This pr addresses a part of #941 consigned with implementing an ohttp gateway middleware.

too many merge conflicts while trying to rebase #1306 , so i decied to abandon that all together and start a new one.
i had gemini help with writing most of the tests .

Pull Request Checklist

Please confirm the following before requesting review:

This pr addresses a part of 941 consigned with implementing an ohttp
gateway middleware.
@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 27063675194

Coverage increased (+0.1%) to 85.474%

Details

  • Coverage increased (+0.1%) from the base build.
  • Patch coverage: 14 uncovered changes across 3 files (282 of 296 lines covered, 95.27%).
  • 2 coverage regressions across 1 file.

Uncovered Changes

File Changed Covered %
payjoin-mailroom/src/ohttp_gateway/error.rs 21 13 61.9%
payjoin-mailroom/src/ohttp_gateway/mod.rs 246 242 98.37%
payjoin-mailroom/src/directory.rs 25 23 92.0%
Total (4 files) 296 282 95.27%

Coverage Regressions

2 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
payjoin-mailroom/src/directory.rs 2 86.11%

Coverage Stats

Coverage Status
Relevant Lines: 14842
Covered Lines: 12686
Line Coverage: 85.47%
Coverage Strength: 367.87 hits per line

💛 - Coveralls

@DanGould

Copy link
Copy Markdown
Contributor

This is looking pretty good to me, so I'm bumping it, but prioritizing #1610

@zealsham

Copy link
Copy Markdown
Collaborator Author

This is looking pretty good to me, so I'm bumping it, but prioritizing #1610

Sure! , I’ll do rebase once #1610 goes in and fix any conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants