Validate FFI primitive inputs + refresh bindings/tests #1263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Pull Request Test Coverage Report for Build 21528486102Details
💛 - Coveralls |
chavic
force-pushed
the
chavic/primitives-validation
branch
2 times, most recently
from
cd3391a to
a44a282
Compare
chavic
force-pushed
the
chavic/primitives-validation
branch
2 times, most recently
from
59affc6 to
93bc4e8
Compare
chavic
force-pushed
the
chavic/primitives-validation
branch
from
24a6794 to
036ddac
Compare
chavic
force-pushed
the
chavic/primitives-validation
branch
from
036ddac to
c13d6b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #1262 and hardens the FFI boundary by validating primitive inputs and surfacing explicit errors. Updates integration tests/bindings to match the new error shapes and removes silent acceptance of invalid fee rates/amounts.
Follow-ups
Decide final script/witness size caps and document rationale.
Add Dart integration fix for large fee rate parsing (separate PR).