Fix nested type inheritance conversion - #171
Open
Munishwar001 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes conversion of Java inheritance clauses when the base type is a nested type (e.g., Outer.Inner), ensuring the declaring type qualifier is preserved in the generated C#.
Changes:
- Update
TypeHelper.GetSyntaxFromType(ClassOrInterfaceType)to consultClassOrInterfaceType.getScope()and emit aQualifiedName(Outer.Inner) when a scope is present. - Add
ConvertNestedTypeInheritanceTeststo cover nested-typeextends/implementsand a non-nested inheritance sanity check.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| JavaToCSharp/TypeHelper.cs | Preserves nested type qualification by incorporating JavaParser scope into the emitted C# type syntax. |
| JavaToCSharp.Tests/ConvertNestedTypeInheritanceTests.cs | Adds regression tests validating nested-type inheritance qualification is retained and simple inheritance remains unchanged. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GeneratorFactory.AbstractXmlFeatureGeneratorFactory), the declaringtype qualifier was silently dropped, producing invalid/incorrect C#
(
AbstractXmlFeatureGeneratorFactoryinstead ofGeneratorFactory.AbstractXmlFeatureGeneratorFactory).TypeHelper.GetSyntaxFromTypeonly readClassOrInterfaceType.getNameAsString(), which returns just thesimple name. JavaParser exposes the declaring type separately via
getScope(), which was never consulted.getScope()and,if present, recursively resolve it and wrap the result in a
QualifiedName, preservingOuter.Innerqualification (valid inboth Java and C#).
Test plan
ConvertNestedTypeInheritanceTestsreproducing the exactscenario from Nested types in inheritance are not converted properly #137 (class extending/implementing nested types keeps
the
GeneratorFactory.qualifier).extendsisunaffected.
dotnet test— 337/337 passed.