Fix publish_pandas docstring to match actual signature and behavior#21
Merged
abhishek-pattern merged 2 commits intofeature/snowflake-s3-stage-v1from Mar 2, 2026
Merged
Conversation
…, update chunk_size and quote_identifiers docs Co-authored-by: abhishek-pattern <129820441+abhishek-pattern@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Work in progress to address feedback on Feature/snowflake s3 stage PR
Fix Mar 2, 2026
publish_pandas docstring to match actual signature and behavior
abhishek-pattern
merged commit c6d63f4
into
feature/snowflake-s3-stage-v1
9 of 10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
publish_pandasdocstring was out of sync with the function's actual parameters and defaults after recent refactoring.Changes
table_schema→table_definition: Corrected parameter name in docstring to match the actual signaturechunk_size: Replaced stale "dump all rows at once / 100k in stored proc" description with accurate "auto-estimated viaestimate_chunk_size(df)" semanticsquote_identifiers: Corrected implied default fromTruetoFalse✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.