[bia-rivera1018]

Summary

This pull request is about PatternFly React issue #12600 and adds separate autocomplete options for the username and password fields.

Changes Made

• Added usernameAutoComplete and passwordAutoComplete properties to LoginForm.
• Updated both input fields to use their own autocomplete values.
• Added tests to check that the correct values are used.

Testing

• All 8 LoginForm tests passed.
• Checked the changes for formatting errors using git diff --check.

Related Issue

#12600

Summary by CodeRabbit

• New Features
  • Login forms now support configurable autocomplete values for the username and password fields.

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

LoginForm now accepts optional autocomplete values for the username and password inputs. It passes each value to the corresponding TextInput. The test checks both configured attributes.

Changes

Login form autocomplete

Layer / File(s)	Summary
Autocomplete props and input forwarding packages/react-core/src/components/LoginPage/LoginForm.tsx, packages/react-core/src/components/LoginPage/__tests__/LoginForm.test.tsx	LoginFormProps adds optional username and password autocomplete values. LoginForm forwards each value to the corresponding input. The test checks both attributes.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Feature

Suggested reviewers: rebeccaalpert, wise-king-sullyman

Merge Risk: Minimal · up to a9af4

No actionable merge-blocking risk was identified.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: adding autocomplete support to LoginForm inputs.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

CodeRabbit Verify

• Run CodeRabbit Verify to test the changes in this pull request.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 027cd646-37f3-4b87-8ae1-ec5676d99841

Commits

Reviewing files that changed from the base of the PR and between 75b6b80 and a9af4f5.

Files selected for processing: 2

• packages/react-core/src/components/LoginPage/LoginForm.tsx
• packages/react-core/src/components/LoginPage/__tests__/LoginForm.test.tsx

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.