Skip to content

fix(react-drag-drop): support dynamic root element IDs in DragDropCon… #12240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arpanroy41 wants to merge 4 commits into
base: main
Choose a base branch
from
+7 −1
Open

fix(react-drag-drop): support dynamic root element IDs in DragDropCon… #12240

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d9fc9cc
fix(react-drag-drop): support dynamic root element IDs in DragDropCon…
arpanroy41 Feb 6, 2026
49c785f
perf: memoize root element lookup to avoid repeated DOM queries
arpanroy41 Feb 6, 2026
f4bd4d6
fix(DragDropContainer): handle case when DOM is not available by retu…
arpanroy41 Feb 6, 2026
107f967
feat(DragDropContainer): add appendTo prop for customizable drag over…
arpanroy41 Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/react-drag-drop/src/components/DragDrop/DragDropContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ export interface DragDropContainerProps extends DndContextProps {
variant?: 'default' | 'DataList' | 'DualListSelectorList';
/** Additional classes to apply to the drag overlay */
overlayProps?: any;
/** The parent container to append the drag overlay to. Defaults to document.body. */
appendTo?: HTMLElement | (() => HTMLElement);
}

export const DragDropContainer: React.FunctionComponent<DragDropContainerProps> = ({
Expand All @@ -77,6 +79,7 @@ export const DragDropContainer: React.FunctionComponent<DragDropContainerProps>
onCancel = () => {},
variant = 'default',
overlayProps,
appendTo = () => document.body,
...props
}: DragDropContainerProps) => {
const itemsCopy = useRef<Record<string, DraggableObject[]> | null>(null);
Expand Down Expand Up @@ -288,6 +291,9 @@ export const DragDropContainer: React.FunctionComponent<DragDropContainerProps>
};

const dragOverlay = <DragOverlay>{activeId && getDragOverlay()}</DragOverlay>;

const portalTarget = typeof appendTo === 'function' ? appendTo() : appendTo || document.body;

return (
<DndContext
sensors={sensors}
Expand All @@ -299,7 +305,7 @@ export const DragDropContainer: React.FunctionComponent<DragDropContainerProps>
{...props}
>
{children}
{canUseDOM ? ReactDOM.createPortal(dragOverlay, document.getElementById('root')) : dragOverlay}
{canUseDOM && portalTarget ? ReactDOM.createPortal(dragOverlay, portalTarget) : dragOverlay}
</DndContext>
);
};
Expand Down
Loading