Call OnEvicted when Set replaces an expired item - #193
Open
AshSgDe29071999 wants to merge 1 commit into
Open
Conversation
Get misses expired keys, but Set still overwrote the slot without running OnEvicted, so resources the callback was meant to release leaked. Live overwrites still do not evict. See patrickmn#176
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getmisses expired keys, butSetstill overwrote the slot without runningOnEvicted, so resources the callback was meant to release leaked.Call
OnEvictedwhen replacing an expired item. A live overwrite still does not evict.Fixes #176
Test
go test . -run TestOnEvictedExpiredOverwrite -count=1