Skip to content

Fix GLC at low inlet concentration, validation and units - #24

Merged
milanofthe merged 3 commits into
masterfrom
fix/glc-issue-22
Nov 10, 2026
Merged

milanofthe merged 3 commits into
masterfrom
fix/glc-issue-22

Conversation

@milanofthe

Copy link
Copy Markdown
Member

Fixes #22.

  • Gas phase scaled by the equilibrium ratio (w = y_T2 / nu), so all states are of order one at any inlet concentration.
  • Gas-limited regime (k >= 1e3, k ~ 1/c_T_in): closed-form leading-order limit for both BCs, agreeing with the solve to 3.2/k. A tritium-free inlet gives zero exactly.
  • Initial mesh graded towards the gas inlet and outlet layers, and a lower bound on the scaled gas inlet, which removes the square-root singularity at a T2-free inlet under O-C.
  • g argument used (from steps-re), flow_g documented as molar flow, parameter and input validation, NaN passed through.
  • Requires pathsim 0.30.3 (cold restart after a failed warm start, graded initial mesh).

@milanofthe
milanofthe merged commit 6255ad1 into master Nov 10, 2026
5 checks passed
@milanofthe
milanofthe deleted the fix/glc-issue-22 branch November 10, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GLC: bugs found in testing after the move from pathsim-chem

2 participants