Repository navigation
Pass a NaN flow rate through IonisationChamber as a NaN signal - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #17 (#4).
IonisationChambercomputed the concentration asflux_in / flow_rate if flow_rate > 0 else 0.0. Becausenan > 0is False, a NaN flow rate gave a signal of exactly 0, so a broken upstream block looked like a clean "nothing detected". It now gives a NaN signal; the flux still passes through unchanged.Zero and negative flow rates still give a zero signal, as before. I didn't make a negative flow raise: implicit solvers can try negative values while iterating, so raising inside
updatecould stop a valid run.Adds a regression test, which fails on the current code.
Open question, not changed here:
detection_efficiency(and the value returned byfunc_efficiency) is only checked to be non-negative, so values above 1 are accepted. That's fine if it is meant as a calibration factor, but if it is strictly an efficiency, it should be limited to [0, 1].