Skip to content

Add Bubbler4 physics and event tests - #19

Merged
jhdark merged 1 commit into
pathsim:masterfrom
jhdark:more-bubbler-tests
Nov 4, 2026
Merged

jhdark merged 1 commit into
pathsim:masterfrom
jhdark:more-bubbler-tests

Conversation

@jhdark

@jhdark jhdark commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Adds TestTritiumBubbler4Physics: tests only, no source changes. Each test checks against hand-derived values:

  • every output with distinct values on each input and parameter, so a swapped port or parameter fails;
  • the four efficiency limits (0/1 for each efficiency), where the tritium distribution and the balance are exact;
  • per-vial replacement timing (each vial restarts at its own time, the others are untouched) and a replacement at the final time;
  • out-of-order replacement times are rejected;
  • solver independence (EUF, RKCK54, ESDIRK43 give the same inventories);
  • two instances in one simulation keep separate states and events;
  • sim.reset() followed by a rerun reproduces the first run.

All pass on current master. I also checked that the tests detect injected bugs (swapped ports, wrong vial rate terms, wrong sample_out, resets hitting the wrong vial or all vials, per-vial times collapsed to one schedule, outputs in the wrong order); each one fails at least one new test, including one the existing suite missed (all vials resetting on vial 1's schedule).

@jhdark
jhdark merged commit 60efc47 into pathsim:master Nov 4, 2026
5 checks passed
@jhdark
jhdark deleted the more-bubbler-tests branch November 4, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant