Repository navigation
Add Bubbler4 physics and event tests - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
TestTritiumBubbler4Physics: tests only, no source changes. Each test checks against hand-derived values:sim.reset()followed by a rerun reproduces the first run.All pass on current master. I also checked that the tests detect injected bugs (swapped ports, wrong vial rate terms, wrong
sample_out, resets hitting the wrong vial or all vials, per-vial times collapsed to one schedule, outputs in the wrong order); each one fails at least one new test, including one the existing suite missed (all vials resetting on vial 1's schedule).