Repository navigation
fix: stage outside patches under the gitignored directory - #318
Merged
Merged
Conversation
An outside patch was copied to .patchloom-<id>/ at the workspace root. .gitignore only ignores .patchloom/, so the copy showed up in source control during preview and stayed if the editor quit first. npm run check: 505 tests, 92.97% lines. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
cmd.exe treats a trailing backslash as an escape. Through patchloom.cmd that joined the path to the next argument, or ate the closing quote. Those arguments are quoted and the trailing slashes are doubled. npm run check: 505 tests, 92.96% lines. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
Escape on that question took the same path as Skip that file, so the other selected configs were still written. Dismiss now cancels the command. Skip still drops only the VS Code workspace file. npm run check: 506 tests, 92.97% lines. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.patchloom/, which git already ignores. The old directory was.patchloom-<id>/at the workspace root, so the copy showed up in source control during the preview and stayed if the editor quit before cleanup..patchloom/.patchloom.cmdargument that ends in a backslash is quoted, and the trailing slashes are doubled, socmd.exedoes not swallow the next argument.Test plan
npm run check(506 unit tests, line coverage 92.97%,vsce package)