Repository navigation
fix: make palette, preview, and MCP setup match the CLI - #317
Merged
Merged
Conversation
Commands stay available in a new folder and when the status bar is hidden. The status bar opens Show Status, and the full report goes to the Output channel. Workspace MCP entries use the command name patchloom. The native server follows the core or full setting. Windows npm shims launch through cmd.exe. Quick Action and batch previews run in the workspace and ask before writing. Undo can target a session or a path, and search hits open from a list. Closes #298 Closes #299 Closes #300 Closes #301 Closes #302 Closes #303 Closes #304 Closes #305 Closes #306 Closes #307 Closes #308 Closes #309 Closes #310 Closes #311 Closes #312 Closes #313 Closes #314 Closes #315 Closes #316 Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // `/s` strips one leading quote and the last quote. Callers that set | ||
| // windowsVerbatimArguments must supply that pair. A host that quotes | ||
| // argv itself (native MCP) must not get a second pair. | ||
| const commandLine = verbatim ? `"${script}"` : script; |
Comment on lines
+55
to
+60
| const result = await execFileAsync(launch.file, launch.args, { | ||
| ...options, | ||
| encoding: "utf8", | ||
| shell: launch.shell, | ||
| windowsVerbatimArguments: launch.windowsVerbatimArguments | ||
| }); |
A blank comSpec falls through to the real COMSPEC path on Windows CI. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
Batch Apply, Patch Apply, and Patch Merge treated every non-zero preview as a failure. The CLI exits 2 with ok true and applied false when that preview would change files, so the write confirmation never appeared. Exit 2 is accepted only on the dry run. A real --apply still requires exit 0, and patch merge exit 8 stays a conflict. Probed with patchloom 0.37.1. npm run check: 504 tests, 92.95% lines. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
A three-way merge that conflicts exits 8 and does not write, with or without --apply. The preview warned and then still asked to Apply, and confirming reported that the merge completed. Exit 8 now stops after the warning. Allow conflict markers still previews as exit 2 and can be written. Probed with patchloom 0.37.1. npm run check: 505 tests, 92.97% lines. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commandaspatchloom. A stale path is rewritten. Windsurf may keep the resolved path. The native server followspatchloom.mcpSurface. Writing.vscode/mcp.jsonwarns that it adds a second server.patchloom.cmdandpatchloom.batlaunch throughcmd.exe /d /s /c.patchloom-preview, not an untitled buffer.ok: trueandapplied: false. That result still reaches the write confirmation. The write itself still requires exit 0. A conflicting merge preview (exit 8) stops and does not offer Apply. Allow conflict markers still previews as exit 2 and can be written.Closes #298
Closes #299
Closes #300
Closes #301
Closes #302
Closes #303
Closes #304
Closes #305
Closes #306
Closes #307
Closes #308
Closes #309
Closes #310
Closes #311
Closes #312
Closes #313
Closes #314
Closes #315
Closes #316
Test plan
npm run check(505 unit tests, line coverage 92.97%,vsce package)