fix: treat unset PASSBOLT_PLUGINS_JWT_AUTHENTICATION_ENABLED as true#249
Closed
0nelight wants to merge 1 commit intopassbolt:masterfrom
Closed
fix: treat unset PASSBOLT_PLUGINS_JWT_AUTHENTICATION_ENABLED as true#2490nelight wants to merge 1 commit intopassbolt:masterfrom
0nelight wants to merge 1 commit intopassbolt:masterfrom
Conversation
Enables JWT key creation by default when the environment variable is not set. This aligns with the documented default and matches behavior seen in bare-metal / non-Docker installations.
Contributor
|
Hey 👋, Thank you again, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Ensures the default value of
PASSBOLT_PLUGINS_JWT_AUTHENTICATION_ENABLED(True) is set so that the JWT key pair is generated at container initialization. This ensures the Docker setup mirrors the default JWT authentication setup behavior found in bare-metal installations. fixes #243Before
Keys were only generated if the env var was explicitly set to
"true".After
true(keys generated if missing)"true"→ same as before"false"/ empty / other → no generationWhy needed
The default value
truefor JWT Authentication (set indefaults.php) does not apply to the bash entrypoint/healthcheck scripts in Docker images. We must explicitly mirror this default in the bash logic to match bare-metal behavior in containerized deployments.Changes
-z "${VAR+xxx}") to the condition