release: 2.0.1, sign without re-aligning so F-Droid can reproduce the APK - #45
Merged
Merged
Conversation
Coverage (core/security)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
release.ymlsigns withapksigner --alignment-preserved true --v1-signing-enabled false.changelogs/20001.txtin all 9 locales. No app code changes.Why
F-Droid's build of
v2.0.0is byte-identical to ours (same sha256 as a local unsigned build), but the published APK did not verify after F-Droid copied its signature onto that build (CHUNKED_SHA512 digest mismatch).apksignerreplaced AGP's zero-byte alignment padding with its own0xd935extra field, which moved every uncompressed entry by 4 bytes. With the alignment preserved, the signed APK is the unsigned zip plus the signing block. The v1 scheme is not needed at minSdk 26.The 2.0.0 APK already on GitHub cannot be matched, so F-Droid starts from 2.0.1.
Testing
apksigcopier comparepasses. The same check on the published 2.0.0 APK reproduces F-Droid's error.StoreMetadataTestpasses (CHANGELOG versionCode matchesversion.properties).Not verified: the release workflow itself; it runs on the
v2.0.1tag.