fix(ci): restore OIDC for CLI publishing - #817
Merged
Merged
Conversation
|
I hit an error while handling your request (Model unavailable on AI Gateway free tier: Free tier users do not have access to this model. Upgrade to paid credits at https://vercel.com/d?to=%2F%5Bteam%5D%2F%7E%2Fai%3Fmodal%3Dtop-up for unrestricted…). Please try again, rephrase, or reach out if it keeps failing. Error id: 190b58a6-1cbb-4bc2-9ecd-61df79e3b4ec |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI publish step fell back to the repository npm token after trusted publishing was introduced. The current token now requires an OTP, so
@pascal-app/cli@1.0.0-beta.2could not publish.This restores the intended tokenless OIDC path for the CLI. npm still needs the package trusted-publisher mapping for
pascalorg/editor,.github/workflows/release.yml, and thenpmenvironment before the release can succeed.Validation:
git diff --check.Note
Low Risk
CI-only change to CLI publish authentication; no application runtime impact, though releases depend on npm trusted-publisher configuration being correct.
Overview
The Publish CLI step in
release.ymlno longer setsNODE_AUTH_TOKENfromsecrets.NPM_TOKEN, sonpm publishcan use GitHub OIDC trusted publishing (the job already requestsid-token: writeand runs in thenpmenvironment).A comment documents that token auth must stay unset for that exchange. Other packages in the workflow still publish with the legacy npm token; only the CLI path is aligned with the intended tokenless flow that was broken when the step inherited token auth.
Reviewed by Cursor Bugbot for commit 58f668b. Bugbot is set up for automated code reviews on this repo. Configure here.