Repository navigation
[Maintainer] i18n follow-ups from the #1148 review #1155
Description
Deferred P2 findings from the Codex review of #1148 (#1148 (review)). They'll be handled in the i18n migration PRs that follow #1148.
- Placeholder validation depth (
scripts/i18n.ts): catch renumbered tags, broken nesting, removedselectbranches and missingotherbranches in translated messages. - Per-locale entry points (
locales.ts): load only the active locale's catalog instead of bundling all five up front. - Plural rules for fallback messages (
registry.ts): aptmessage used forpt-PTshould usept's plural rules, notpt-PT's. - In-app
?lang=navigation (layout.tsx): switch the language on client navigation without a reload.
Next owner: Maintainer.
Activity
Aymericr commentedon Oct 27, 2026
One more item from Security's review of #1148 (L1):
proxy()function, plus matcher tests inapps/editor/proxy.test.ts. Today's tests call the helpers directly. [Bugs] Editor proxy: harden middleware matcher #1156's matcher tests on main cover part of this.Aymericr commentedon Oct 27, 2026
One more item from Security's review of #1148 (L2b):
scripts/i18n.ts(~line 195):<img/src=x onerror=...>,<svg/onload=...>and<!-- -->still get past tag validation. It isn't exploitable, because translations render as text. To fix it, treat any<followed by a letter,!or/as a tag, and add test cases.Aymericr commentedon Oct 27, 2026
#1148 merged as 374b781. One more item from Tooling's review:
bun run testnow runs the i18n script tests outside Turbo's cache, which takes about 66s locally. Move them into a cached Turbo task, or scope them to changes underscripts/.Bugbot's open findings on #1148 (scoped-locale parse, decimal write-back, floor-plan number formatting, SSR snapshot) are being fixed in a separate follow-up PR, not tracked here.