Skip to content

refactor(hir-ty): deepen type system module#318

Merged
hongjr03 merged 12 commits into
masterfrom
refactor/hir-type-system
Jul 25, 2026
Merged

refactor(hir-ty): deepen type system module#318
hongjr03 merged 12 commits into
masterfrom
refactor/hir-type-system

Conversation

@hongjr03

Copy link
Copy Markdown
Member

Summary

  • introduce an opaque, cheaply cloned Type and a TypeSystem facade so IDE features no longer depend on Salsa query results or the internal type representation
  • narrow the Salsa adapter to expression and path-resolution queries, and split inference, member operations, compatibility/packed width, and the internal type model into focused private modules
  • migrate completion and extract-variable code actions to the facade, centralizing compatibility policy and removing direct arena-owner handling from callers
  • move embedded tests to integration tests against the public type-system interface

Verification

  • cargo test -p hir-ty
  • cargo test -p ide
  • cargo check --workspace
  • started the vide LSP, opened a SystemVerilog document, and confirmed member completion for value. returned bar and foo

@hongjr03
hongjr03 merged commit 7f3bbdc into master Jul 25, 2026
16 of 18 checks passed
@hongjr03
hongjr03 deleted the refactor/hir-type-system branch July 25, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant