Skip to content

fix: usergroup create/update with system roles - #1860

Merged
nikhilsinhaparseable merged 2 commits into
parseablehq:mainfrom
nikhilsinhaparseable:fix/usergroup-system-role
Nov 17, 2026
Merged

nikhilsinhaparseable merged 2 commits into
parseablehq:mainfrom
nikhilsinhaparseable:fix/usergroup-system-role

Conversation

@nikhilsinhaparseable

@nikhilsinhaparseable nikhilsinhaparseable commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

fix the behaviour - usergroup cannot be created or updated
when attaching system roles __global_ingestor__ or __global_querier__ to it

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; the previous group-only query permission issue is fixed.

Summary

Allows groups to use __global_ingestor__ and __global_querier__ while keeping other internal roles protected.

  • User groups can carry global roles and pass their access to members.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
    Group[Group roles] --> Resolve[role_for]
    Resolve --> System[Fixed system role]
    Resolve --> Tenant[Tenant-defined role]
    System --> Permissions[Group permissions]
    Tenant --> Permissions
    Permissions --> Auth[Request access check]
    Permissions --> Query[Query permission check]
Loading

Reviews (2) · Last reviewed commit: "fix for get permissions" · Reviewed by Greptile

fix the behaviour - usergroup cannot be created or updated
when attaching system roles `__global_ingestor__` or `__global_querier__` to it
Comment thread src/rbac/map.rs Resolved
@nikhilsinhaparseable
nikhilsinhaparseable merged commit fa42d43 into parseablehq:main Nov 17, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants