Repository navigation
fix: usergroup create/update with system roles - #1860
Merged
nikhilsinhaparseable merged 2 commits intoNov 17, 2026
Merged
nikhilsinhaparseable merged 2 commits into
nikhilsinhaparseable merged 2 commits into
Conversation
fix the behaviour - usergroup cannot be created or updated when attaching system roles `__global_ingestor__` or `__global_querier__` to it
parmesant
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix the behaviour - usergroup cannot be created or updated
when attaching system roles
__global_ingestor__or__global_querier__to it

Confidence Score: 5/5
The PR appears safe to merge; the previous group-only query permission issue is fixed.Summary
Allows groups to use
__global_ingestor__and__global_querier__while keeping other internal roles protected.Diagram
%%{init: {'theme': 'neutral'}}%% flowchart LR Group[Group roles] --> Resolve[role_for] Resolve --> System[Fixed system role] Resolve --> Tenant[Tenant-defined role] System --> Permissions[Group permissions] Tenant --> Permissions Permissions --> Auth[Request access check] Permissions --> Query[Query permission check]Reviews (2) · Last reviewed commit: "fix for get permissions" · Reviewed by Greptile