Skip to content

fix: global query user to have access to list stream#1611

Merged
nikhilsinhaparseable merged 1 commit intoparseablehq:mainfrom
nikhilsinhaparseable:fix-list-stream-mt
Apr 2, 2026
Merged

fix: global query user to have access to list stream#1611
nikhilsinhaparseable merged 1 commit intoparseablehq:mainfrom
nikhilsinhaparseable:fix-list-stream-mt

Conversation

@nikhilsinhaparseable
Copy link
Copy Markdown
Contributor

@nikhilsinhaparseable nikhilsinhaparseable commented Apr 2, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Updated authorization logic to allow list stream operations under global ingestion/query permissions, consistent with other similar operations.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 96581ec6-3a64-42aa-af9d-3a952b2154a1

📥 Commits

Reviewing files that changed from the base of the PR and between 187a4e6 and 3869257.

📒 Files selected for processing (1)
  • src/rbac/map.rs

Walkthrough

The Sessions::check_auth method in src/rbac/map.rs now includes Action::ListStream as an eligible action in the global-ingestion/global-query authorization branch, treating it alongside existing Action::Ingest and Action::Query actions when resource type is absent.

Changes

Cohort / File(s) Summary
RBAC Authorization Logic
src/rbac/map.rs
Added Action::ListStream as eligible action in the global-ingestion/global-query authorization branch alongside Action::Ingest and Action::Query when resource_type is None.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 A stream of permissions flows through,
ListStream joins the authorized crew,
Alongside Ingest, Query so grand,
Authorization rules expand their command!

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is empty, failing to provide any context, rationale, or information about the changes made. Add a detailed description following the repository template, including the issue reference, description of the goal, rationale, key changes, and testing checklist items.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: enabling list stream access for global query users.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@nikhilsinhaparseable nikhilsinhaparseable merged commit 4559ae6 into parseablehq:main Apr 2, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants