Skip to content

chore: upgrade dependencies - #64

Merged
nikhilsinhaparseable merged 1 commit into
mainfrom
bump-deps
Nov 12, 2026
Merged

nikhilsinhaparseable merged 1 commit into
mainfrom
bump-deps

Conversation

@praveen5959

@praveen5959 praveen5959 commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

RetriggerView in GreptileConfidence Score: 4/5

The PR appears safe to merge, with non-blocking gaps in how the new smoke test runs and what it checks.

Fix All in CodexFindings

  1. P2 CI skips the smoke test ▶
  2. P2 Datasource health is not checked ▶
Fix with agent prompt
### Issue 1
package.json:8
The workflows do not start Grafana or invoke `yarn e2e`, so the new test cannot catch plugin-loading failures before merge. Add a job that builds the plugin, starts Grafana, installs Chromium, and runs the test.

### Issue 2
e2e/plugin-smoke.spec.ts:9-13
The test checks plugin metadata and a plugin page, but never checks a datasource connection. It can pass when the backend cannot reach Parseable, despite the datasource-health coverage promised in `CHANGELOG.md`. Add a health check for a configured datasource and assert its result.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

This PR upgrades Go and JavaScript dependencies, aligns the Go version across build environments, and replaces the old Cypress smoke test with Playwright.

  • The datasource builds with updated Go and JavaScript tools.
  • Playwright checks that Grafana loads the Parseable datasource plugin.

Reviews (1) · Last reviewed commit: "chore: upgrade dependencies" · Reviewed by Greptile

Comment thread package.json Resolved
Comment thread e2e/plugin-smoke.spec.ts Resolved
@nikhilsinhaparseable
nikhilsinhaparseable merged commit 40a5849 into main Nov 12, 2026
3 checks passed
@nikhilsinhaparseable
nikhilsinhaparseable deleted the bump-deps branch November 12, 2026 06:58
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants