You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Changed zombienet binary, encountered issue where relative paths in zombienet.toml were not working so also intorduced PROJECT_ROOT env variable which is used in zombienet.toml like default_command = "{{PROJECT_ROOT}}/.bin/polkadot"
@RafalMirowski1, I think you could separate the process of building whatever is necessary (this would use the ci-unified image), and once you have all the binaries built (or maybe downloaded from cache) you could then have a separate step (which uses ubuntu image) to run the zombienet network and tests
I guess the questions are:
why do we need to use ci-unified image? - IMHO, if we need to build any rust project, its good to re-use the image that polkadot-sdk uses for runtime builds reproducibility etc
do we need to use ci-unified image for non-rust related stuff? - I think we dont need to
can we run ubuntu images on parity runners? - I think we can find examples of this in the wild so I guess its not an issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#28
Changed zombienet binary, encountered issue where relative paths in zombienet.toml were not working so also intorduced
PROJECT_ROOTenv variable which is used inzombienet.tomllikedefault_command = "{{PROJECT_ROOT}}/.bin/polkadot"