Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Migrate pallet-lottery to pallet attribute macro#8762

Merged
5 commits merged intoparitytech:masterfrom
shaunxw:sw/migrate-pallet-lottery
May 12, 2021
Merged

Migrate pallet-lottery to pallet attribute macro#8762
5 commits merged intoparitytech:masterfrom
shaunxw:sw/migrate-pallet-lottery

Conversation

@shaunxw
Copy link
Copy Markdown
Contributor

@shaunxw shaunxw commented May 8, 2021

Part of #7882.

Converts the Lottery pallet to the new pallet attribute macro introduced in #6877.

Following the upgrade guidelines here: https://crates.parity.io/frame_support/attr.pallet.html#upgrade-guidelines.

⚠️ Breaking Change ⚠️

From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines

storages now use PalletInfo for module_prefix instead of the one given to decl_storage: Thus any use of this pallet in construct_runtime! should be careful to update name in order not to break storage or to upgrade storage (moreover for instantiable pallet). If pallet is published, make sure to warn about this breaking change.

So users of the Lottery pallet must be careful about the name they used in construct_runtime!. Hence the runtime-migration label, which might not be needed depending on the configuration of the Lottery pallet.

Loading
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants