feat(truapi): expose current product context - #504
Open
pgherveou wants to merge 6 commits into
Open
Conversation
pgherveou
commented
Aug 25, 2026
pgherveou
marked this pull request as ready for review
August 25, 2026 12:19
valentinfernandez1
approved these changes
Aug 25, 2026
valentinfernandez1
left a comment
valentinfernandez1
left a comment
Collaborator
There was a problem hiding this comment.
Code looks good, I cross validated with cli host and it works as expected. Just have one small nit
Great work 👍🏻
Collaborator
Author
|
@valentunn @johnthecat implemented the quick RFC from #503 can you add your +1 so we can merge this |
TarikGul
reviewed
Aug 25, 2026
|
|
||
| /// Response containing the product context bound to the current host runtime. | ||
| #[derive(Debug, Clone, PartialEq, Eq, Encode, Decode)] | ||
| pub struct GetProductContextResponse { |
Member
There was a problem hiding this comment.
GetProductContextResponse is the only payload type here without a domain prefix, the rest are Host* or Remote*, and the versioned enum wrapping this one is HostGetProductContextResponse. Rename to HostGetProductContextResponse for consistency?
Collaborator
Author
There was a problem hiding this comment.
yeah right, ideally we would just drop all these Host prefix, but maybe we can just keep it for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
system.getProductContext()so products can query the full canonical identifier already bound to the host runtime.{ productId }before account pairing, without product-side network detection or normalizationVerification
Workspace build, strict clippy, all-target tests, WASM check, codegen goldens, and TypeScript package builds and tests pass.
Closes #503
Authored with assistance from Codex.