feat(platform): auto-grant remote permissions to trusted product labels - #446
Merged
Conversation
Product-id TLDs split from the narrower dotNS navigation list so .test is a product scope without bypassing the outbound domain grant.
valentinfernandez1
approved these changes
Aug 20, 2026
Resolves the `.test` TLD question in main's favour. #465 widened DOTNS_TLDS to cover `test` and asserts that a `.test` name classifies as dotNS navigation, so the DOTNS_TLDS/PRODUCT_ID_TLDS split this branch introduced is gone along with its superset test and the two navigate cases that expected `.test` to stay external. Product-id validation and the trusted-label lookup read DOTNS_TLDS. Domain-bundle resolution keeps main's shape — BundleResolution, the set-shaped key for a multi-domain denial — with the trusted-label auto-grant layered in: resolve_domains consults effective_domain_status, so a trusted product resolves as authorized and never reaches the prompt, while a stored decision still wins. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #434.
REMOTE_PERMISSION_TRUSTED_LABELS(peopl,dim2,stash) holds everyRemotePermissionwithout a prompt; nothing is persisted, and a storedDeniedstill revokes it.PRODUCT_ID_TLDSaddstestfor product ids only. The dotNS navigation list staysdot/paseo, so a.testhost remains external and keeps consuming a domain grant.