Skip to content

Add polkadot-bulletin-chain as submodule#1263

Open
mudigal wants to merge 13 commits into
mainfrom
nm-bulletin-submodule
Open

Add polkadot-bulletin-chain as submodule#1263
mudigal wants to merge 13 commits into
mainfrom
nm-bulletin-submodule

Conversation

@mudigal
Copy link
Copy Markdown

@mudigal mudigal commented May 12, 2026 •
edited
Loading

Summary

  • Add polkadot-bulletin-chain as a git submodule under submodules/
  • Replace Bulletin chainspec files with symlinks to the submodule for Polkadot, Westend, and Paseo

Note

This PR depends on paritytech/polkadot-bulletin-chain#523 being merged first, as the symlinks reference chainspecs/ from that repo.

Reference

@mudigal mudigal requested a review from karolk91 May 12, 2026 17:42
@mudigal mudigal mentioned this pull request May 12, 2026
Merged
@bkontur
Copy link
Copy Markdown
Contributor

bkontur commented May 13, 2026

@mudigal we should also update the main README.md https://raw.githubusercontent.com/paritytech/chainspecs/refs/heads/main/README.md

@mudigal
Copy link
Copy Markdown
Author

mudigal commented May 13, 2026

@mudigal we should also update the main README.md https://raw.githubusercontent.com/paritytech/chainspecs/refs/heads/main/README.md

Good point - updated Readme

@x3c41a x3c41a mentioned this pull request May 14, 2026
Closed
x3c41a added 3 commits May 14, 2026 16:33
@x3c41a
Retarget symlinks to flat layout and bump submodule
72ae462 
- chainspec.json symlinks now point at chainspecs/<network>-chainspec.json
- Add paseo-next-v2 symlink for paseo/parachain/bulletin-next
- Restore raw.json / genesis-head as regular files (not tracked upstream)
- Bump polkadot-bulletin-chain submodule to merged #523
@x3c41a
Remove stale submodules/watr gitlink
932cc3f 
The submodule entry was removed from .gitmodules in #1101 because the
upstream Watr-Protocol/watr repo is no longer accessible, but the gitlink
itself was left in the tree. Submodule checkout has been failing on every
PR since with: fatal: No url found for submodule path 'submodules/watr'.
@x3c41a
Remove leftover polkadot/parachain/watr broken symlink
c74a8e5 
PR #1101 removed the watr submodule from .gitmodules; this is the
matching symlink that pointed into it.
bkontur
bkontur reviewed May 14, 2026
View reviewed changes
Comment thread README.md Outdated
- [Paseo Coretime](paseo/parachain/coretime/chainspec.json)
- [Paseo People](paseo/parachain/people/chainspec.json)
- [Paseo People Next](paseo/parachain/people-next/chainspec.json)
- [Paseo Bulletin](paseo/parachain/bulletin/chainspec.json)
Copy link
Copy Markdown
Contributor

@bkontur bkontur May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@x3c41a bulletin-next and bulletin-next-v2

Copy link
Copy Markdown

@x3c41a x3c41a May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, fixed!

bkontur
bkontur reviewed May 18, 2026
View reviewed changes
Comment thread README.md Outdated
Comment on lines +130 to +131
- [Paseo Bulletin Next](paseo/parachain/bulletin/chainspec.json)
- [Paseo Bulletin Next v2](paseo/parachain/bulletin-next/chainspec.json)
Copy link
Copy Markdown
Contributor

@bkontur bkontur May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@x3c41a I think think paseo/parachain/bulletin/chainspec.json is not obvious which paseo are we talking about. I would keep the "convention".

Suggested change
- [Paseo Bulletin Next](paseo/parachain/bulletin/chainspec.json)
- [Paseo Bulletin Next v2](paseo/parachain/bulletin-next/chainspec.json)
- [Paseo Bulletin Next](paseo/parachain/bulletin-next/chainspec.json)
- [Paseo Bulletin Next v2](paseo/parachain/bulletin-next-v2/chainspec.json)

Copy link
Copy Markdown

@x3c41a x3c41a May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair

Copy link
Copy Markdown
Contributor

@bkontur bkontur May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair

please, also align subfolder:
paseo/parachain/bulletin/chainspec.json -> paseo/parachain/bulletin-next/chainspec.json
paseo/parachain/bulletin-next/chainspec.json -> paseo/parachain/bulletin-next-v2/chainspec.json

@x3c41a x3c41a requested a review from bkontur May 18, 2026 10:32
@bkontur
Copy link
Copy Markdown
Contributor

bkontur commented May 20, 2026

@x3c41a please, remove also all of those raw.json e.g. paseo/parachain/bulletin-next-v2/raw.json and genesis-heads

@x3c41a
Remove raw.json and genesis-head for bulletin parachains
09cc802 
These derived artifacts are no longer tracked in the source repo and can
be regenerated from the canonical chainspec.json symlinked here.
@x3c41a
Copy link
Copy Markdown

x3c41a commented May 20, 2026

@x3c41a please, remove also all of those raw.json e.g. paseo/parachain/bulletin-next-v2/raw.json and genesis-heads

removed

@x3c41a x3c41a enabled auto-merge (squash) May 20, 2026 11:34
@x3c41a x3c41a disabled auto-merge May 20, 2026 11:36
@bkontur
Copy link
Copy Markdown
Contributor

bkontur commented May 20, 2026

@x3c41a why did you remove submodules/watr? It is not related to the Bulletin, right?

@x3c41a
Copy link
Copy Markdown

x3c41a commented May 20, 2026

@x3c41a why did you remove submodules/watr? It is not related to the Bulletin, right?

yes, it's not.

I did not notice that Claude cleaned up leftover submodules. Extract that clean up to a separate PR - #1265

@bkontur bkontur enabled auto-merge (squash) May 20, 2026 20:41
@bkontur
Copy link
Copy Markdown
Contributor

bkontur commented May 20, 2026

@nprt could you please review/merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkontur bkontur bkontur approved these changes

@x3c41a x3c41a x3c41a approved these changes

@karolk91 karolk91 Awaiting requested review from karolk91

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mudigal @bkontur @x3c41a