Skip to content

new stack and improved skills.#142

Open
krisnye wants to merge 1 commit intomainfrom
knye/stack
Open

new stack and improved skills.#142
krisnye wants to merge 1 commit intomainfrom
knye/stack

Conversation

@krisnye
Copy link
Collaborator

@krisnye krisnye commented Mar 11, 2026

  • the ecs skill has been simplified to direct the AI to use the node_modules/@adobe/data/AGENTS.md file. This allows ai improvements to be published from adobe/data itself, keeping improvements more cohesive. This pattern has been recommended for using all published packages that contain AGENTS.md files.
  • adding aidd-stack skill to advise on tech stacks based upon requirements. The recommendations can be expanded.
  • aidd-structure skill improved
  • new aidd-ts-projects skill to teach how to properly use simple tsconfig files with project references to constrain dependencies.


Simple, high performance with good agentic integration. Designed for modeling both persistent application state and transient rendering/ui state.

### Redux

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible redundancy with stack.mdc in rules, line 29-39 https://github.com/paralleldrive/aidd/blob/main/ai/rules/stack.mdc

`# Redux

Avoid Redux Toolkit. Use frameworks/redux/autodux and redux connect instead.

  1. Build the Autodux dux object and save it as "${slice name}-dux.sudo"
  2. Transpile to JavaScript and save it as "${slice name}-dux.js"

Constraints {
ALWAYS use tdd as defined in tdd.mdc when implementing source code changes.
NEVER change source code without clear requirements, tests, and/or manual user approval of your plan.
}`

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Eric pointed out we have to remove that and merge any missing logic needed into this.

@ericelliott
Copy link
Collaborator

@cursoragent please /review

Make sure there's a reference in AGENTS.md to ref to stack.
Stack should should be in aidd-custom/skills/stack/SKILL.md and fall back to ai/skills/stack/SKILL.md

@cursor
Copy link
Contributor

cursor bot commented Mar 12, 2026

Code Review Findings

🔴 Critical Issues

1. Missing AGENTS.md Reference

The AGENTS.md file lacks a reference to the stack skill. Based on the pattern in the file, there should be an entry like:

## Task Index

fix bug => /aidd-fix
choose stack => /stack

Location: /workspace/AGENTS.md

2. Incorrect Skill Naming and Location

The stack skill is currently at:

  • ai/skills/aidd-stack/SKILL.md

But according to your requirements, it should be:

  • aidd-custom/skills/stack/SKILL.md (project-specific, primary)
  • ai/skills/stack/SKILL.md (framework default, fallback)

The naming convention should be stack, not aidd-stack, when it's meant to be a customizable/overridable skill.

3. Redundancy with Existing Rules

As @orionnye noted in the PR comments, there's significant redundancy between:

# Redux

Avoid Redux Toolkit. Use frameworks/redux/autodux and redux connect instead.

1. Build the Autodux dux object and save it as "${slice name}-dux.sudo"
2. Transpile to JavaScript and save it as "${slice name}-dux.js"

Constraints {
  ALWAYS use tdd as defined in tdd.mdc when implementing source code changes.
  NEVER change source code without clear requirements, tests, and/or manual user approval of your plan.
}

And:

### Redux

Avoid Redux Toolkit. Use frameworks/redux/autodux and redux connect instead.

1. Build the Autodux dux object and save it as "${slice name}-dux.sudo"
2. Transpile to JavaScript and save it as "${slice name}-dux.js"

Constraints {
  ALWAYS use tdd as defined in tdd.mdc when implementing source code changes.
  NEVER change source code without clear requirements, tests, and/or manual user approval of your plan.
}

This is nearly identical content in two locations, violating DRY principles.

⚠️ High Priority Issues

4. Missing aidd-custom/skills/ Directory Structure

The aidd-custom/ directory exists but lacks the skills/ subfolder referenced in its README:

| `skills/`             | Custom project-specific skills                     |

5. Incomplete Migration Strategy

The .cursor/rules/stack.mdc file contains NextJS + React/Redux + Shadcn-specific guidance (lines 11-28) that isn't present in the new aidd-stack skill. If .cursor/rules/stack.mdc is to be deprecated in favor of the skill, this content needs to be preserved or merged.

📋 Recommendations

  1. Create the proper directory structure:

    • Create aidd-custom/skills/stack/
    • Move/rename ai/skills/aidd-stack/SKILL.md to ai/skills/stack/SKILL.md
  2. Update AGENTS.md to include a reference to the stack skill in the "Task Index" section

  3. Consolidate redundant content:

    • Merge any unique content from .cursor/rules/stack.mdc into the stack skill
    • Either deprecate .cursor/rules/stack.mdc or have it reference the skill
    • The skill should be the single source of truth for stack guidance
  4. Document the override pattern:

    • Make it clear that aidd-custom/skills/stack/SKILL.md overrides ai/skills/stack/SKILL.md
    • This allows projects to customize stack recommendations while maintaining framework defaults

Would you like me to implement these fixes, or would you prefer to review the findings first?

Open in Web Open in Cursor 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants