Skip to content

fix(tdd): add cross-reference to requirements.mdc#129

Open
ianwhitedeveloper wants to merge 2 commits intomainfrom
fix/tdd-requirements-cross-reference
Open

fix(tdd): add cross-reference to requirements.mdc#129
ianwhitedeveloper wants to merge 2 commits intomainfrom
fix/tdd-requirements-cross-reference

Conversation

@ianwhitedeveloper
Copy link

Summary

  • Adds an explicit callout in tdd.mdc directing agents to read and apply requirements.mdc before authoring given/should strings
  • Placed immediately above the assert type definition — the highest-leverage intercept point
  • Path reference follows the established project convention (bare filename, no ai/rules/ prefix)

Closes #127

Test plan

  • All 183 unit tests pass
  • Lint and typecheck clean
  • Both ai/rules/tdd.mdc and .cursor/rules/tdd.mdc are in sync
  • Cross-reference path style matches existing project conventions (requirements.mdc, not ai/rules/requirements.mdc)
  • Reviewed by sub-agent — PASS

Made with Cursor

Copy link

@orionnye orionnye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

ai/rules/tdd.mdc Outdated

## assert

> Before authoring `given`/`should` strings, read and apply `requirements.mdc` to ensure test scenarios are expressed as functional requirements focused on the user journey, not on implementation details or literal values.
Copy link
Collaborator

@ericelliott ericelliott Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps just import @requirements.mdc on a one-line constraint and mention that it should use them for given/should strings.

@ianwhitedeveloper ianwhitedeveloper force-pushed the fix/tdd-requirements-cross-reference branch from 27ad1ab to 2a8880a Compare March 6, 2026 00:58
Directs agents to read requirements.mdc before authoring given/should strings, ensuring test scenarios are expressed as user-journey-focused functional requirements rather than implementation details or literal values. Closes #127.

Made-with: Cursor
Replace blockquote callout with a one-line @requirements.mdc constraint inside Constraints {}, matching the established @import pattern used in task-creator.mdc and user-testing.mdc.

Made-with: Cursor
@ianwhitedeveloper ianwhitedeveloper force-pushed the fix/tdd-requirements-cross-reference branch from 2a8880a to fb9731f Compare March 18, 2026 16:56
@janhesters
Copy link
Collaborator

@ianwhitedeveloper This branch is based on v2.6.0 (ee15c31) and carries the old ai/rules/ restructuring that has since been reverted on main. The ai/rules/ directory no longer exists on mainrequirements.mdc is now at ai/skills/aidd-functional-requirements/SKILL.md.

This branch needs to be rebased onto current main and the cross-reference fix applied to the current skill structure (i.e., ai/skills/aidd-tdd/SKILL.md referencing ai/skills/aidd-functional-requirements/SKILL.md).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tdd.mdc: Add explicit reference to requirements.mdc to mitigate invalid test scenario authoring

4 participants