feat(ext): land bookmark-all-tabs on main (#46)#51
Merged
Conversation
Adds a "Save all tabs" popup button that saves every http(s) tab in the current window in one batched bookmarks.json write. core: - addBookmarks(file, bookmarks, nowIso): pure, replay-safe batch append that de-dupes by URL against existing *active* bookmarks and within the batch. Tombstoned URLs aren't treated as duplicates (re-save allowed). Exported. extension-shared: - bookmark-factory: optional `folder` input (default ""). - save-flow: saveAllTabs(...) + SaveAllTabsResult (shared SaveFailure type, reuses classify). Pre-filters unsafe schemes via isSafeBookmarkUrl, builds a bookmark per safe tab, then one updateBookmarksOrBootstrap call whose mutator applies addBookmarks; reports saved / skippedUnsafe / skippedDuplicate / total. - save-result-view: applySaveAllResult(...) — count message + Saved ✓ + auto-close. - popup: "Save all tabs" button (magenta secondary) + handler. Restricts the batch to http(s) tabs (isSafeBookmarkUrl also allows chrome:/about:, which aren't useful bookmarks); groups saves into a dated `Session YYYY-MM-DD` folder. manifests: add the `tabs` permission (chrome + firefox). NOTE: this widens the install prompt to "Read your browsing history" — needed to read every tab's url/title. tests: addBookmarks (5), saveAllTabs (6), applySaveAllResult (3). docs: CLAUDE.md roadmap item 8 -> done; smoke-test steps in both READMEs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
feat(ext): bookmark all open tabs in one action (#46)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #46.
PR #50 was merged into its stacked base (
feat/extension-ui-polish) rather thanmain, so the bookmark-all-tabs work never reachedmainand #46 stayed open (GitHub only auto-closes linked issues on merges to the default branch). This PR lands that exact commit onmain.The diff is precisely PR #50's changes — PR #49's content already merged to
main, so the only delta betweenfeat/extension-ui-polishandmainis the bookmark-all-tabs work:core:addBookmarks(dedupe-safe batch append) + export.extension-shared:saveAllTabs+SaveAllTabsResult,applySaveAllResult,bookmark-factoryfolder option, popup "Save all tabs" button/handler.tabspermission (both).Already verified on the branch: core 82 tests, extension-shared 115 tests, typecheck + builds clean.
🤖 Generated with Claude Code