Fix `.partition(":") usage on potential IPv6 addresses#6096
Open
lkk7 wants to merge 2 commits into
Open
Conversation
lkk7
commented
Jul 14, 2026
| port = int(port) | ||
| elif sn_port: | ||
| port = int(sn_port) | ||
| elif sn_port is not None: |
Author
There was a problem hiding this comment.
sn_port changed to int/none, that's the reason for this change
lkk7
commented
Jul 14, 2026
|
|
||
| try: | ||
| run_simple(t.cast(str, host), port, self, **options) | ||
| run_simple(host, port, self, **options) |
lkk7
commented
Jul 14, 2026
|
|
||
| self._update_cookies_from_response( | ||
| ctx.request.host.partition(":")[0], | ||
| urlsplit(ctx.request.host_url).hostname or "localhost", |
Author
There was a problem hiding this comment.
That's the part I was unsure about.
Hostname can be None, so I used the behavior from the werkzeug change you mentioned:
hostname = url.hostname or "localhost"
lkk7
commented
Jul 14, 2026
|
|
||
| if server_name: | ||
| sn_host, _, sn_port = server_name.partition(":") | ||
| server_url = urlsplit(f"//{server_name}") |
Author
There was a problem hiding this comment.
I added "//" to make urlsplit work in this instance. I assume that this won't break anything, but you definitely know more about that.
Author
|
Not sure about the reason of "Development Versions" fail... |
Member
|
Dev tests are not updated for Werkzeug main yet, they're expected to fail until next Werkzeug release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix two usages of
.partition(":")on potential IPv6 addresses.Replace them with alternatives.
Fixes #6093