Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently depend on a very old and not longer maintained version of Feign. Upgrading is tricky because there are a number of subtle behavior changes in the latest version of Feign - see #1337. This code is quite ossified, so even small behavior changes are likely to cause problems.
This is starting to cause conflicts with consumers are also depending on modern version of Feign.
This PR addresses the issue by removing our Feign dependency. This is accomplished by vendoring the code from the version of Feign we currently depend on.
This PR is divided into a series of commits in order to make reviewing easier:
Vendor Feign as is into
conjure-java-jaxrs-clientChange the package from
feigntocom.palantir.conjure.java.client.jaxrs.feignRemove unused code and suppress warnings
This includes some small refactors if those refactors allowed us to eliminate more code.
Move all classes to the
com.palantir.conjure.java.client.jaxrsconjure-java-jaxrs-clientcurrently exposes a lot of it's internals. Changing the interfaces that our classes implement is an already an ABI, so we should take the opportunity to address this deficiency while we are breaking the API.There are a small handful of internal consumers that are importing some of the
feignimplclasses. But it is small enough (roughly 13 files across 8 repos), that this change should be acceptable.