feat(website): add Korean (ko-KR) translation#200
Open
moduvoice wants to merge 2 commits into
Open
Conversation
Add ko-KR.json locale matching the en-US structure and register ko-KR in the website's localeMap so it appears in the language switcher.
"다시 정의하다" is a verb infinitive, which reads awkwardly as an isolated heading fragment paired with "ePub 리더" below it. Use the noun form "재정의" instead, consistent with the ja-JP locale's use of "再定義" for the same string.
|
@moduvoice is attempting to deploy a commit to the pacexy Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Korean (ko) translation PR body template
Motivation
This adds Korean (
ko) translation support — to help Korean-speaking users use thisopen-source project more comfortably in their own language.
한국 사람들의 오픈소스 이용에 도움이 되게 하기 위해서 한글화 작업을 하였습니다.
Changes
apps/website/locales/ko-KR.json(new file), a full Korean translation ofen-US.jsonwith all 43 leaf keys present, matching its nested structure 1:1.'ko-KR': '한국어'inapps/website/i18n.js'slocaleMap, which is the only place outsidelocales/that references other locale codes — this makes ko-KR appear in the language switcher automatically (locales = Object.keys(localeMap)).ja-JP/zh-CNlocales (e.g.hl=ko,/ko-kr/,/ko/path segments).donate_urlkept ashttps://ko-fi.com/pacexy, same asen-US/ja-JP/zh-CN(this is the project's actual donation link, not something to localize).Scope note: this repo has a second, separate locale system at
apps/reader/locales(.tsfiles:en-US.ts,ja-JP.ts,zh-CN.ts,de-DE.ts). It was intentionally not touched here to keep this PR focused and reviewable — it would make a good follow-up PR if maintainers are open to it.Testing
ko-KR.jsonis valid JSON and its leaf keys are an exact 1:1 match withen-US.json(43/43, no missing or extra keys) via a small script comparing recursively flattened key paths.apps/website/i18n.jsneeded and now has theko-KRentry, and that it is the only non-locales/file referencing other locale codes (grep -rl "ja-JP" apps/website ...outsidelocales/returns onlyi18n.js).en-US.jsonand cross-checked phrasing/URL conventions againstja-JP.jsonfor naturalness and consistency.