Repository navigation
Conversation
Doome161
marked this pull request as draft
October 25, 2026 19:31
Doome161
marked this pull request as ready for review
October 25, 2026 19:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR introduces optional lightweight node shadows as a performance-oriented alternative to
QGraphicsDropShadowEffect.The existing shadow implementation can be expensive when rendering multiple nodes, particularly during interactive operations such as dragging and zooming.
The new implementation draws a soft shadow approximation directly in
DefaultNodePainterusing translucent rounded rectangles, avoiding the overhead of a separate graphics effect.Changes
NodeStyle::FastShadowEnabled(default:false).NodeGraphicsObjectto skipQGraphicsDropShadowEffectwhen lightweight shadows are enabled.DefaultNodePainter.Usage
Enable lightweight shadows through
NodeStyle:Compatibility
The feature is strictly opt-in. Existing applications retain their current rendering behavior without modifications.
Trade-offs:
Testing
Added
TestFastNodeShadows.cpp, covering:Note: The regression tests have been implemented but have not yet been independently executed and verified. Performance benchmarks and visual testing across different zoom levels and DPI settings are also recommended.
Breaking changes?
No breaking changes are intended.
The new
FastShadowEnabledproperty defaults tofalse, preserving existing behavior and visual appearance.Related issue
Related to #121 — Maximum Zoom In causes improper node rendering.
This PR provides an optional alternative to the existing graphics effect. It does not claim to resolve the underlying Qt caching issue (QTBUG-77400).
The existing workaround using
ShadowEnabled = falseremains available.