Skip to content

feat: establish verification baseline — test/typecheck/CI gate (#62)#70

Merged
pablopunk merged 1 commit into
mainfrom
fractal-doce-dev-work-62-establish-verification-baseline-test-typecheck-s-ded04e
Jun 17, 2026
Merged

feat: establish verification baseline — test/typecheck/CI gate (#62)#70
pablopunk merged 1 commit into
mainfrom
fractal-doce-dev-work-62-establish-verification-baseline-test-typecheck-s-ded04e

Conversation

@pablopunk

Copy link
Copy Markdown
Owner

Summary

Closes #62. Establishes a verification baseline so every change is sound before it reaches main or publishes a Docker image.

What changed

  • vitest.config.ts — scopes tests to src/**/*.test.ts with @/* alias
  • Scripts (package.json) — typecheck, test, check (biome → typecheck → test → build)
  • 11 TypeScript errors fixed — null safety in chat.ts, exactOptionalPropertyTypes fixes, missing job types, store handler payload typing
  • 3 test failures fixed — sanitize regex patterns required 16+ char keys; errorToSanitizedMessage(undefined) now returns "undefined"
  • 2 test files converted to vitestjob-state.test.ts and composeFailure.test.ts now use describe/it/expect
  • CI gatedcheck job runs on PRs and push to main; Docker publish only proceeds on push after check passes
  • AGENTS.md — Astro v5 → v6; verification commands table added
  • Queue type allowlists alignedproject.descriptionSync and project.identityGenerate now present in both status.ts and jobs-stream.ts

Verification

pnpm test:      3 files | 19 tests | 19 passed
pnpm typecheck: exits 0
pnpm check:     biome ✓ | typecheck ✓ | test ✓ | build ✓ → exits 0

- Add vitest.config.ts scoping tests to src/**/*.test.ts
- Add typecheck, test, check scripts to package.json
- Fix all TypeScript errors (chat.ts null checks, exactOptionalPropertyTypes, missing job types, store handler types)
- Convert hand-rolled test files to vitest (job-state, composeFailure)
- Fix 3 sanitize test failures (min-length regex match, undefined error handling)
- Gate CI: check job with biome+typecheck+test+build before Docker publish on push, also runs on PRs
- Fix AGENTS.md: Astro v5 → v6, add verification commands table
- Align queue job type allowlists across status.ts and jobs-stream.ts
@vercel

vercel Bot commented Jun 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
doce-dev-www Ready Ready Preview, Comment Jun 17, 2026 1:29pm

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@pablopunk, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 59 minutes and 56 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f9c74730-37b1-4c48-9dfa-7b6d3ff569f5

📥 Commits

Reviewing files that changed from the base of the PR and between 98cf4a1 and d801b91.

📒 Files selected for processing (14)
  • .github/workflows/docker-build.yml
  • AGENTS.md
  • package.json
  • src/actions/chat.ts
  • src/lib/chat/attachmentPromptText.ts
  • src/pages/api/queue/jobs-stream.ts
  • src/server/docker/composeFailure.test.ts
  • src/server/opencode/normalize.ts
  • src/server/queue/job-state.test.ts
  • src/server/settings/status.ts
  • src/server/utils/sanitize.test.ts
  • src/server/utils/sanitize.ts
  • src/stores/useChatStore.interactionHandlers.ts
  • vitest.config.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot temporarily deployed to pr-70 June 17, 2026 13:30 Destroyed
@pablopunk pablopunk merged commit 5ec6301 into main Jun 17, 2026
10 checks passed
@pablopunk pablopunk deleted the fractal-doce-dev-work-62-establish-verification-baseline-test-typecheck-s-ded04e branch June 17, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Establish a verification baseline: test/typecheck scripts, vitest config, fix failing checks, gate CI

1 participant