Skip to content

perf: optimize re filter - #484

Draft
dkharms wants to merge 1 commit into
mainfrom
355-re-optimization
Draft

perf: optimize re filter#484
dkharms wants to merge 1 commit into
mainfrom
355-re-optimization

Conversation

@dkharms

@dkharms dkharms commented Aug 3, 2026

Copy link
Copy Markdown
Member

Description

TBA

Fixes #355


  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

If you have used LLM/AI assistance please provide model name and full prompt:

Model: {{model-name}}
Prompt: {{prompt}}

@dkharms dkharms added the performance Features or improvements that positively affect seq-db performance label Aug 3, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.80556% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.26%. Comparing base (8cf7b08) to head (0584fca).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
parser/token_re.go 82.05% 10 Missing and 4 partials ⚠️
pattern/pattern.go 92.06% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #484      +/-   ##
==========================================
+ Coverage   71.16%   71.26%   +0.09%     
==========================================
  Files         232      232              
  Lines       18466    18596     +130     
==========================================
+ Hits        13142    13253     +111     
- Misses       4341     4355      +14     
- Partials      983      988       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dkharms

dkharms commented Aug 3, 2026

Copy link
Copy Markdown
Member Author

@seqbenchbot start search-hot main --query 'transaction_id:re(".needle.")'

@seqbenchbot

seqbenchbot commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Nice, @dkharms <(-^,^-)=b!

Started benchmark 21098564.

Show details
  • scenario search-hot;
  • against main;
  • running for 10m0s;

I'll post the statistics here once it finishes.
To end it early, run @seqbenchbot stop 21098564.

Here is a list of helpful links:

  • Take a look at Grafana dashboard;
  • Live-tailing logs are also available;

Have a great time!

@dkharms

dkharms commented Aug 3, 2026

Copy link
Copy Markdown
Member Author

@seqbenchbot stop 21098564

@seqbenchbot

seqbenchbot commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Roger, @dkharms <(-^,^-)=b!

Stopping benchmark 21098564.
I'll post its statistics here once it wraps up.

@seqbenchbot

Copy link
Copy Markdown
Collaborator

Nice, @dkharms <(-^,^-)=b!

Benchmark 21098564 (scenario search-hot) has finished.
I've prepared a summary for you. Click on Show summary button to see it:

Show summary
Query Type mean (ms) stddev (ms) p(50) (ms) p(95) (ms) p(99) (ms) iterations
bulk
warm 26.81 7.74 25.00 40.00 58.00 2457.00
transaction_id:re(".*needle.*")
warm 7658.29 647.38 7651.00 8502.00 9090.00 206.00

Compare it against another run with @seqbenchbot compare 21098564 <other-id>.

@dkharms

dkharms commented Aug 3, 2026

Copy link
Copy Markdown
Member Author

@seqbenchbot start search-hot 355-re-optimization --query 'transaction_id:re(".needle.")'

@seqbenchbot

seqbenchbot commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Nice, @dkharms <(-^,^-)=b!

Started benchmark 0f43f597.

Show details
  • scenario search-hot;
  • against 355-re-optimization;
  • running for 10m0s;

I'll post the statistics here once it finishes.
To end it early, run @seqbenchbot stop 0f43f597.

Here is a list of helpful links:

  • Take a look at Grafana dashboard;
  • Live-tailing logs are also available;

Have a great time!

@dkharms

dkharms commented Aug 3, 2026

Copy link
Copy Markdown
Member Author

@seqbenchbot stop 0f43f597

@seqbenchbot

seqbenchbot commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Roger, @dkharms <(-^,^-)=b!

Stopping benchmark 0f43f597.
I'll post its statistics here once it wraps up.

@seqbenchbot

Copy link
Copy Markdown
Collaborator

Nice, @dkharms <(-^,^-)=b!

Benchmark 0f43f597 (scenario search-hot) has finished.
I've prepared a summary for you. Click on Show summary button to see it:

Show summary
Query Type mean (ms) stddev (ms) p(50) (ms) p(95) (ms) p(99) (ms) iterations
bulk
warm 27.39 8.01 26.00 42.00 59.00 2457.00
transaction_id:re(".*needle.*")
warm 16.21 10.05 15.00 18.00 23.50 2070.00

Compare it against another run with @seqbenchbot compare 0f43f597 <other-id>.

@dkharms

dkharms commented Aug 3, 2026

Copy link
Copy Markdown
Member Author

@seqbenchbot start search-hot main --query 'transaction_id:re("tx-cafe.*")'

@seqbenchbot

seqbenchbot commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Nice, @dkharms <(-^,^-)=b!

Started benchmark a89d5cb1.

Show details
  • scenario search-hot;
  • against main;
  • running for 10m0s;

I'll post the statistics here once it finishes.
To end it early, run @seqbenchbot stop a89d5cb1.

Here is a list of helpful links:

  • Take a look at Grafana dashboard;
  • Live-tailing logs are also available;

Have a great time!

@dkharms

dkharms commented Aug 3, 2026

Copy link
Copy Markdown
Member Author

@seqbenchbot stop a89d5cb1

@seqbenchbot

seqbenchbot commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Roger, @dkharms <(-^,^-)=b!

Stopping benchmark a89d5cb1.
I'll post its statistics here once it wraps up.

@seqbenchbot

Copy link
Copy Markdown
Collaborator

Nice, @dkharms <(-^,^-)=b!

Benchmark a89d5cb1 (scenario search-hot) has finished.
I've prepared a summary for you. Click on Show summary button to see it:

Show summary
Query Type mean (ms) stddev (ms) p(50) (ms) p(95) (ms) p(99) (ms) iterations
bulk
warm 27.03 7.54 25.00 41.00 54.50 2457.00
transaction_id:re("tx-cafe.*")
warm 1259.38 85.20 1256.00 1380.50 1446.00 2788.00

Compare it against another run with @seqbenchbot compare a89d5cb1 <other-id>.

@dkharms

dkharms commented Aug 3, 2026

Copy link
Copy Markdown
Member Author

@seqbenchbot start search-hot 355-re-optimization --query 'transaction_id:re("tx-cafe.*")'

@seqbenchbot

seqbenchbot commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Nice, @dkharms <(-^,^-)=b!

Started benchmark c57b4150.

Show details
  • scenario search-hot;
  • against 355-re-optimization;
  • running for 10m0s;

I'll post the statistics here once it finishes.
To end it early, run @seqbenchbot stop c57b4150.

Here is a list of helpful links:

  • Take a look at Grafana dashboard;
  • Live-tailing logs are also available;

Have a great time!

@dkharms

dkharms commented Aug 3, 2026

Copy link
Copy Markdown
Member Author

@seqbenchbot stop c57b4150

@seqbenchbot

seqbenchbot commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Roger, @dkharms <(-^,^-)=b!

Stopping benchmark c57b4150.
I'll post its statistics here once it wraps up.

@seqbenchbot

Copy link
Copy Markdown
Collaborator

Nice, @dkharms <(-^,^-)=b!

Benchmark c57b4150 (scenario search-hot) has finished.
I've prepared a summary for you. Click on Show summary button to see it:

Show summary
Query Type mean (ms) stddev (ms) p(50) (ms) p(95) (ms) p(99) (ms) iterations
bulk
warm 26.70 7.26 25.00 39.00 54.00 2457.00
transaction_id:re("tx-cafe.*")
warm 5.29 2.81 5.00 6.00 7.00 2177.00

Compare it against another run with @seqbenchbot compare c57b4150 <other-id>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Features or improvements that positively affect seq-db performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimizations for re filter

3 participants