Skip to content

select CI toolchains explicitly - #1058

Draft
danieleades wants to merge 2 commits into
oxidecomputer:mainfrom
danieleades:ci-explicit-toolchains
Draft

select CI toolchains explicitly#1058
danieleades wants to merge 2 commits into
oxidecomputer:mainfrom
danieleades:ci-explicit-toolchains

Conversation

@danieleades

Copy link
Copy Markdown
Contributor

Summary

  • remove the repository-level rust-toolchain.toml pin;
  • select the intended Rust toolchain explicitly in each CI job;
  • test stable on Linux, macOS, and Windows;
  • add a nightly Linux test without changing unrelated action versions.

Relationship to #938

This is stacked on #938, which declares and checks the project's MSRV. The current diff therefore includes #938 until that PR merges; after it lands, this PR should be rebased onto main and will contain only the toolchain-policy and CI-matrix changes.

rust-toolchain.toml is useful for pinning a contributor toolchain, but it does not declare or enforce the minimum Rust version supported by downstream consumers. #938 establishes that contract. This follow-up removes the contributor pin and makes each CI toolchain choice explicit instead.

Validation

  • formatting and workspace tests pass;
  • the MSRV check from add MSRV check to CI #938 passes on Rust 1.88;
  • stable CI covers Linux, macOS, and Windows;
  • nightly CI covers Linux.

@danieleades
danieleades force-pushed the ci-explicit-toolchains branch from aa773a6 to f04c84f Compare July 28, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant