Conversation
lgfa29
approved these changes
Feb 13, 2026
Member
lgfa29
left a comment
lgfa29
left a comment
There was a problem hiding this comment.
Forgot to click the button 🤦
It may be better to remote the automated commit and do the API update in a separate PR to keep workstreams separated.
jmcarp
force-pushed
the
jmcarp/drop-redundant-checks
branch
3 times, most recently
from
409e571 to
47e6844
Compare
The golangci-lint tool includes various other linters, including staticcheck and goimports. This patch configures golangci-lint to do the work that was being done by other standalone linters, then drops the other linters from our configs.
sudomateo
force-pushed
the
jmcarp/drop-redundant-checks
branch
from
fe209b9 to
47ba862
Compare
sudomateo
reviewed
Feb 16, 2026
sudomateo
reviewed
Feb 16, 2026
sudomateo
reviewed
Feb 16, 2026
Comment on lines
+27
to
+28
| exclusions: | ||
| generated: disable |
Collaborator
There was a problem hiding this comment.
This runs the formatters on generated files. Specfically, it disables the exclusion logic that would normally exclude generated files from formatters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The golangci-lint tool includes various other linters, including staticcheck and goimports. This patch configures golangci-lint to do the work that was being done by other standalone linters, then drops the other linters from our configs.