Open
Conversation
jmcarp
force-pushed
the
jmcarp/drop-flat-struct
branch
2 times, most recently
from
86f1467 to
0b723bf
Compare
Drop the flat struct pattern for representing tagged unions with multiple value
types, and instead use interfaces with variant types.
Note that we also fix pre-existing bugs related to marshalling and
unmarshalling interface wrapper types. We now correctly serialize nil
interfaces to `null`, rather than `{"type": ""}`, and correspondingly unmarshal
null oneOf fields to `nil`.
jmcarp
force-pushed
the
jmcarp/drop-flat-struct
branch
from
0b723bf to
ff67b95
Compare
lgfa29
approved these changes
Feb 13, 2026
Member
lgfa29
left a comment
lgfa29
left a comment
There was a problem hiding this comment.
I focused mostly in the DESIGN.md and generated output, but changes LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earlier, we switched from
anyto interfaces with variant structs to represent tagged unions with a single value field. We left tagged unions with multiple value fields as flat structs at the time. This patch finishes the migration to interfaces for all tagged unions.Downstream PRs: