Draft
Conversation
andrewjstone
commented
Apr 4, 2026
| .await | ||
| } | ||
|
|
||
| pub(crate) async fn physical_disk_list_uninitialized( |
Contributor
Author
There was a problem hiding this comment.
Should probably just inline all this in the http endpoints. At a minimum it doesn't belong in the sled module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows re-adopting expunged disks, and forcing manual adoption of disks that will be adopted by the disk adoption background task. It implements the determinations in RFD 663, but not the future work.
It's WIP because it needs some self-review with fresh eyes, testing, and a much better PR description.