[inventory] Add svcs enabled not online to DB

[karencfv]

Follow up to #9977
Closes: #9516

Manual testing with no data from services

$ ./target/debug/omdb db inventory collections show latest --db-url "postgresql://root@[::1]:57066/omicron?sslmode=disable"
<...>
SMF SERVICES STATUS
    no data on SMF services has been collected
<...>

Happy system

$ ./target/debug/omdb db inventory collections show latest --db-url "postgresql://root@[::1]:57066/omicron?sslmode=disable"
<...>
SMF SERVICES STATUS
    0 SMF services enabled but not online at 2026-04-01T18:39:24.057Z
<...>

With failed services

$ ./target/debug/omdb db inventory collections show latest --db-url "postgresql://root@[::1]:57066/omicron?sslmode=disable"
<...>
SMF SERVICES STATUS
    3 SMF services enabled but not online at 2026-04-01T17:54:42.261Z
        FMRI                                ZONE       STATE       
        svc:/site/fake-service:default      global     maintenance 
        svc:/site/fake-service3:default     global     offline     
        svc:/site/fake-service4:default     global     degraded    
<...>

With a command error

$ ./target/debug/omdb db inventory collections show latest --db-url "postgresql://root@[::1]:57066/omicron?sslmode=disable"
<...>
SMF SERVICES STATUS
    failed to retrieve SMF services: command failure: Command [/usr/bin/svcs -Za -FAKE -o state,fmri,zone] executed and failed with status: exit status: 2  stdout:   stderr: /usr/bin/svcs: illegal option -- F
    Usage: svcs [-aHpv] [-o col[,col ... ]] [-R restarter] [-sS col] [-Z | -z zone ]
                [<service> ...]
           svcs -d | -D [-Hpv] [-o col[,col ... ]] [-sS col] [-Z | -z zone ]
                [<service> ...]
           svcs [-l | -L] [-Z | -z zone] <service> ...
           svcs -x [-v] [-Z | -z zone] [<service> ...]
           svcs -?
<...>

[jgallagher]

This maybe gets at a design issue with the types on the Rust side, but - what would it mean to have a row in a table named ..._not_online_service with the state online?

[karencfv]

I see where you're getting at 🤔 . What about using an enum on the DB side (inv_svc_not_online_state ?) that does not include the online state?

[jgallagher]

I think not including the online state is the right call, if the intent of this is to store "not online" statuses. But we probably need to remove it on the Rust side too, right? For a couple reasons: the same question applies there (what would it mean for a SvcsEnabledNotOnline to contain a service in the state SvcState::Online), and what would you do at runtime if you had that and needed to store it in the db?

That does make the type names awkward; it probably needs to be something like SvcState becomes NotOnlineSvcState and Svc becomes NotOnlineSvc? I don't love that but it does seem like we probably don't want the generic-sounding Svc and SvcState types to not be able to represent online services.

[karencfv]

Ha! Looks like this was already on my mind 😄
https://github.com/oxidecomputer/omicron/blob/main/sled-agent/types/versions/src/modify_services_in_inventory/inventory.rs#L56-L58

[karencfv]

In the end I decided to keep the SvcState enum for the initial parse() method. It seemed just wrong not have a complete enum of all of the possible states as part of the svcs module. I did add additional enums SvcEnabledNotOnlineState and InvSvcEnabledNotOnlineState for the "enabled not online" filtering functionality.

[jgallagher]

Thanks, I think that makes perfect sense. 👍

[karencfv]

Thanks for the review! I think I've addressed all of your comments @jgallagher

[karencfv]

I see where you're getting at 🤔 . What about using an enum on the DB side (inv_svc_not_online_state ?) that does not include the online state?

[jgallagher]

Changes look good - just one nit with the error string conversion, and then the somewhat-painful "what do we do about online services" question in #10195 (comment).

[karencfv]

Thanks for taking a look @jgallagher! I think this should be ready to go 🤞

[jgallagher]

Thanks for all the work on the back-and-forth here! Looks great.