Reject duplicate static routes in an add request#761
Open
MorganaFuture wants to merge 1 commit into
Open
Conversation
The static routing API accepted multiple routes that share a (prefix, nexthop, vlan_id) but differ only in rib_priority, returned OK, then kept just one: rib_priority is not part of a path's RIB identity, so the entries collapse to a single path. Validate an add request and return HTTP 400 when two routes share a prefix and RIB path identity within the request. The dedup keys on the Path identity the RIB itself uses, so it stays in lockstep. This covers duplicates within a single request; the deeper data-model change (a map keyed by the triple, enforced at deserialize) is left for a follow-up. Closes oxidecomputer#739
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The static routing API accepted multiple routes that share a
(prefix, nexthop, vlan_id)but differ only inrib_priority, returned OK, then kept only one -rib_priorityis not part of a path's RIB identity, so the entries collapse to a single path.This validates an add request and returns HTTP 400 when two routes share a prefix and RIB path identity within the request, keying the check on the same
Pathidentity the RIB uses. It covers duplicates within a single request; the deeper data-model change (a map keyed by the triple, enforced at deserialize) is left for a follow-up.Tested with unit tests for the validator and the add path; ran the mgd suite.
Closes #739