Remove used_with_arg; add Grapefruit test suite#2539
Open
mkeeter wants to merge 2 commits into
Open
Conversation
labbott
approved these changes
May 27, 2026
mkeeter
force-pushed
the
mkeeter/remove-used-with-arg
branch
3 times, most recently
from
36f4cd5 to
5140032
Compare
mkeeter
force-pushed
the
mkeeter/remove-used-with-arg
branch
from
5140032 to
8a5bdb0
Compare
mkeeter
force-pushed
the
mkeeter/remove-used-with-arg
branch
from
8a5bdb0 to
0e7ce2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We would like to minimize our usage of nightly features. The only place we use
#[used(linker)]is in the test suite, and it's not necessary: we need both#[unsafe(no_mangle)]andpub static mut, but together they preventTESTSfrom being compiled out of the image. It's a bit awkward that we now need anunsafeto access tests, but that's the cost ofpub static mut.